Fix variable initialization with ALTER SUBSCRIPTION DROP PUBLICATION

michaelpq · michaelpq · commit 79718c1c6c00 · 2021-06-28T12:11:18.000+09:00
copy_data is not a supported option with this sub-command of ALTER SUBSCRIPTION, which would not make a variable related to it initialized after parsing the option set in DefElems. A refresh could then refer to it. Author: Ranier Vilela Reviewed-by: Peter Smith Discussion: https://postgr.es/m/CAEudQAp5P8nr=ze2Gv=BMj=DJFZnrvendZCZcC-fos3QiDe2sg@mail.gmail.com
diff --git a/src/backend/commands/subscriptioncmds.c b/src/backend/commands/subscriptioncmds.c
@@ -949,7 +949,7 @@ AlterSubscription(AlterSubscriptionStmt *stmt, bool isTopLevel)
 		case ALTER_SUBSCRIPTION_DROP_PUBLICATION:
 			{
 				bool		isadd = stmt->kind == ALTER_SUBSCRIPTION_ADD_PUBLICATION;
-				bool		copy_data;
+				bool		copy_data = false;
 				bool		refresh;
 				List	   *publist;
 

Original file line number	Diff line number	Diff line change
`@@ -949,7 +949,7 @@ AlterSubscription(AlterSubscriptionStmt *stmt, bool isTopLevel)`
`949`	`949`	`case ALTER_SUBSCRIPTION_DROP_PUBLICATION:`
`950`	`950`	`{`
`951`	`951`	`bool isadd = stmt->kind == ALTER_SUBSCRIPTION_ADD_PUBLICATION;`
`952`		`- bool copy_data;`
	`952`	`+ bool copy_data = false;`
`953`	`953`	`bool refresh;`
`954`	`954`	`List *publist;`
`955`	`955`