Fix use-after-free bug

alvherre · alvherre · commit 8082bea2b06e · 2017-03-24T15:43:15.000-03:00
Detected by buildfarm member prion
diff --git a/src/backend/commands/statscmds.c b/src/backend/commands/statscmds.c
@@ -230,6 +230,12 @@ CreateStatistics(CreateStatsStmt *stmt)
 	statoid = HeapTupleGetOid(htup);
 	heap_freetuple(htup);
 	heap_close(statrel, RowExclusiveLock);
+
+	/*
+	 * Invalidate relcache so that others see the new statistics.
+	 */
+	CacheInvalidateRelcache(rel);
+
 	relation_close(rel, NoLock);
 
 	/*
@@ -250,11 +256,6 @@ CreateStatistics(CreateStatsStmt *stmt)
 
 	ObjectAddressSet(address, StatisticExtRelationId, statoid);
 
-	/*
-	 * Invalidate relcache so that others see the new statistics.
-	 */
-	CacheInvalidateRelcache(rel);
-
 	return address;
 }
 
