report stat() error in trigger file check

bmomjian · bmomjian · commit 83defef8c794 · 2014-04-17T11:55:57.000-04:00
Permissions might prevent the existence of the trigger file from being
checked.

Per report from Andres Freund
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
@@ -11102,6 +11102,12 @@ CheckForStandbyTrigger(void)
 		fast_promote = true;
 		return true;
 	}
+	else if (errno != ENOENT)
+		ereport(ERROR,
+				(errcode_for_file_access(),
+				 errmsg("could not stat trigger file \"%s\": %m",
+						TriggerFile)));
+
 	return false;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -11102,6 +11102,12 @@ CheckForStandbyTrigger(void)`
`11102`	`11102`	`fast_promote = true;`
`11103`	`11103`	`return true;`
`11104`	`11104`	`}`
	`11105`	`+ else if (errno != ENOENT)`
	`11106`	`+ ereport(ERROR,`
	`11107`	`+ (errcode_for_file_access(),`
	`11108`	`+ errmsg("could not stat trigger file \"%s\": %m",`
	`11109`	`+ TriggerFile)));`
	`11110`	`+`
`11105`	`11111`	`return false;`
`11106`	`11112`	`}`
`11107`	`11113`