Remove redundant initialization of a local variable.

tglsfdc · tglsfdc · commit 8c44802b6ed4 · 2018-02-18T23:32:56.000-05:00
In what was doubtless a typo, commit bf6c614 introduced a duplicate initialization of a local variable. This made Coverity unhappy, as well as pretty much anybody reading the code. We don't even have a real use for the local variable, so just remove it.
diff --git a/src/backend/executor/nodeGroup.c b/src/backend/executor/nodeGroup.c
@@ -162,7 +162,6 @@ GroupState *
 ExecInitGroup(Group *node, EState *estate, int eflags)
 {
 	GroupState *grpstate;
-	AttrNumber *grpColIdx = grpColIdx = node->grpColIdx;
 
 	/* check for unsupported flags */
 	Assert(!(eflags & (EXEC_FLAG_BACKWARD | EXEC_FLAG_MARK)));
@@ -209,7 +208,7 @@ ExecInitGroup(Group *node, EState *estate, int eflags)
 	grpstate->eqfunction =
 		execTuplesMatchPrepare(ExecGetResultType(outerPlanState(grpstate)),
 							   node->numCols,
-							   grpColIdx,
+							   node->grpColIdx,
 							   node->grpOperators,
 							   &grpstate->ss.ps);
 
