Commit 8f91f32

committed

Clean up pg_dump tests, re-enable BLOB testing

Add a loop to check that each test covers all of the pg_dump runs. We (I) had been a bit sloppy when adding new runs and not making sure to mark if they should be under like or unlike for each test, this loop makes sure that the test system will complain if any are forgotten in the future. The loop also correctly handles the 'catch all' cases, which are used to avoid running unnecessary specific checks when a single catch-all can be done (eg: a no-acl run should not have any GRANT commands). Also, re-enable the testing of blobs, but use lo_from_bytea() instead of trying to be cute and writing out to a file and then reading it back in with psql, which proved to be difficult for some buildfarm members. This allows us to add support for testing the --no-blobs option which will be getting added shortly, provided the buildfarm doesn't blow up on this.

1 parent a43f193 commit 8f91f32Copy full SHA for 8f91f32

1 file changed

+695

-165

lines changed

src/bin/pg_dump/t
- 002_pg_dump.pl

1 file changed

+695

-165

lines changed

Comments

(0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 8f91f32

1 file changed

1 file changed

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!

File tree

1 file changed

1 file changed

0 commit comments

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!