Fix uninitialized variable from commit a4d75c8.

tglsfdc · tglsfdc · commit 9cb92334092f · 2021-04-11T11:46:46.000-04:00
The path for *exprs != NIL would misbehave, and likely crash,
since pull_varattnos expects its last argument to be valid
at call.

Found by Coverity --- we have no coverage of this path in
the regression tests.
diff --git a/src/backend/statistics/extended_stats.c b/src/backend/statistics/extended_stats.c
@@ -1609,7 +1609,7 @@ statext_is_compatible_clause(PlannerInfo *root, Node *clause, Index relid,
 
 	if (pg_class_aclcheck(rte->relid, userid, ACL_SELECT) != ACLCHECK_OK)
 	{
-		Bitmapset  *clause_attnums;
+		Bitmapset  *clause_attnums = NULL;
 
 		/* Don't have table privilege, must check individual columns */
 		if (*exprs != NIL)

Original file line number	Diff line number	Diff line change
`@@ -1609,7 +1609,7 @@ statext_is_compatible_clause(PlannerInfo root, Node clause, Index relid,`
`1609`	`1609`
`1610`	`1610`	`if (pg_class_aclcheck(rte->relid, userid, ACL_SELECT) != ACLCHECK_OK)`
`1611`	`1611`	`{`
`1612`		`- Bitmapset *clause_attnums;`
	`1612`	`+ Bitmapset *clause_attnums = NULL;`
`1613`	`1613`
`1614`	`1614`	`/* Don't have table privilege, must check individual columns */`
`1615`	`1615`	`if (*exprs != NIL)`