Tweak create_index_paths()'s test for whether to consider a bitmap scan.

tglsfdc · tglsfdc · commit 9d1ac2f5fa40 · 2011-01-11T12:13:02.000-05:00
Per my note of a couple days ago, create_index_paths would refuse to
consider any path at all for GIN indexes if the selectivity estimate came
out as 1.0; not even if you tried to force it with enable_seqscan.  While
this isn't really a bad outcome in practice, it could be annoying for
testing purposes.  Adjust the test for "is this path only useful for
sorting" so that it doesn't fire on paths with nil pathkeys, which will
include all GIN paths.
diff --git a/src/backend/optimizer/path/indxpath.c b/src/backend/optimizer/path/indxpath.c
@@ -196,8 +196,8 @@ create_index_paths(PlannerInfo *root, RelOptInfo *rel)
 			add_path(rel, (Path *) ipath);
 
 		if (ipath->indexinfo->amhasgetbitmap &&
-			ipath->indexselectivity < 1.0 &&
-			!ScanDirectionIsBackward(ipath->indexscandir))
+			(ipath->path.pathkeys == NIL ||
+			 ipath->indexselectivity < 1.0))
 			bitindexpaths = lappend(bitindexpaths, ipath);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -196,8 +196,8 @@ create_index_paths(PlannerInfo root, RelOptInfo rel)`
`196`	`196`	`add_path(rel, (Path *) ipath);`
`197`	`197`
`198`	`198`	`if (ipath->indexinfo->amhasgetbitmap &&`
`199`		`- ipath->indexselectivity < 1.0 &&`
`200`		`- !ScanDirectionIsBackward(ipath->indexscandir))`
	`199`	`+ (ipath->path.pathkeys == NIL \|\|`
	`200`	`+ ipath->indexselectivity < 1.0))`
`201`	`201`	`bitindexpaths = lappend(bitindexpaths, ipath);`
`202`	`202`	`}`
`203`	`203`