Remove a useless cast to (void *) in hash_search() call

petere · petere · commit a274bbb1b365 · 2024-11-14T09:30:14.000+01:00
This pattern was previously cleaned up in 54a177a, but a new instance snuck in around the same time in 31966b1.
diff --git a/src/backend/storage/buffer/localbuf.c b/src/backend/storage/buffer/localbuf.c
@@ -379,7 +379,7 @@ ExtendBufferedRelLocal(BufferManagerRelation bmr,
 		InitBufferTag(&tag, &bmr.smgr->smgr_rlocator.locator, fork, first_block + i);
 
 		hresult = (LocalBufferLookupEnt *)
-			hash_search(LocalBufHash, (void *) &tag, HASH_ENTER, &found);
+			hash_search(LocalBufHash, &tag, HASH_ENTER, &found);
 		if (found)
 		{
 			BufferDesc *existing_hdr;

Original file line number	Diff line number	Diff line change
`@@ -379,7 +379,7 @@ ExtendBufferedRelLocal(BufferManagerRelation bmr,`
`379`	`379`	`InitBufferTag(&tag, &bmr.smgr->smgr_rlocator.locator, fork, first_block + i);`
`380`	`380`
`381`	`381`	`hresult = (LocalBufferLookupEnt *)`
`382`		`- hash_search(LocalBufHash, (void *) &tag, HASH_ENTER, &found);`
	`382`	`+ hash_search(LocalBufHash, &tag, HASH_ENTER, &found);`
`383`	`383`	`if (found)`
`384`	`384`	`{`
`385`	`385`	`BufferDesc *existing_hdr;`