Remove test for NULL node in ExecProcNode(). No place ever calls

tglsfdc · tglsfdc · commit a6bbfedcf7a8 · 2005-04-06T20:13:49.000Z
ExecProcNode() with a NULL value, so the test couldn't do anything
for us except maybe mask bugs.  Removing it probably doesn't save
anything much either, but then again this is a hot-spot routine.
diff --git a/src/backend/executor/execProcnode.c b/src/backend/executor/execProcnode.c
@@ -12,7 +12,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/executor/execProcnode.c,v 1.47 2005/03/25 21:57:58 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/executor/execProcnode.c,v 1.48 2005/04/06 20:13:49 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -271,12 +271,6 @@ ExecProcNode(PlanState *node)
 
 	CHECK_FOR_INTERRUPTS();
 
-	/*
-	 * deal with NULL nodes..
-	 */
-	if (node == NULL)
-		return NULL;
-
 	if (node->chgParam != NULL) /* something changed */
 		ExecReScan(node, NULL); /* let ReScan handle this */
 

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`*`
`13`	`13`	`*`
`14`	`14`	`* IDENTIFICATION`
`15`		`- * $PostgreSQL: pgsql/src/backend/executor/execProcnode.c,v 1.47 2005/03/25 21:57:58 tgl Exp $`
	`15`	`+ * $PostgreSQL: pgsql/src/backend/executor/execProcnode.c,v 1.48 2005/04/06 20:13:49 tgl Exp $`
`16`	`16`	`*`
`17`	`17`	`*-------------------------------------------------------------------------`
`18`	`18`	`*/`
`@@ -271,12 +271,6 @@ ExecProcNode(PlanState *node)`
`271`	`271`
`272`	`272`	`CHECK_FOR_INTERRUPTS();`
`273`	`273`
`274`		`- /*`
`275`		`- * deal with NULL nodes..`
`276`		`- */`
`277`		`- if (node == NULL)`
`278`		`- return NULL;`
`279`		`-`
`280`	`274`	`if (node->chgParam != NULL) /* something changed */`
`281`	`275`	`ExecReScan(node, NULL); /* let ReScan handle this */`
`282`	`276`