Don't try to read default for a non-existent attribute

adunstan · adunstan · commit b85e91023bf3 · 2023-03-15T17:20:42.000-04:00
Oversight in commit 9f8377f for COPY .. DEFAULT per report from Alexander Lakhin
diff --git a/src/backend/commands/copyfromparse.c b/src/backend/commands/copyfromparse.c
@@ -1683,7 +1683,8 @@ CopyReadAttributesText(CopyFromState cstate)
 			strncmp(start_ptr, cstate->opts.null_print, input_len) == 0)
 			cstate->raw_fields[fieldno] = NULL;
 		/* Check whether raw input matched default marker */
-		else if (cstate->opts.default_print &&
+		else if (fieldno < list_length(cstate->attnumlist) &&
+				 cstate->opts.default_print &&
 				 input_len == cstate->opts.default_print_len &&
 				 strncmp(start_ptr, cstate->opts.default_print, input_len) == 0)
 		{
@@ -1897,7 +1898,8 @@ CopyReadAttributesCSV(CopyFromState cstate)
 			strncmp(start_ptr, cstate->opts.null_print, input_len) == 0)
 			cstate->raw_fields[fieldno] = NULL;
 		/* Check whether raw input matched default marker */
-		else if (cstate->opts.default_print &&
+		else if (fieldno < list_length(cstate->attnumlist) &&
+				 cstate->opts.default_print &&
 				 input_len == cstate->opts.default_print_len &&
 				 strncmp(start_ptr, cstate->opts.default_print, input_len) == 0)
 		{
