Fix map_sql_value_to_xml_value() to treat domains like their base types.

tglsfdc · tglsfdc · commit bc6187868205 · 2013-03-03T19:32:22.000-05:00
This was already the case for domains over arrays, but not for domains
over certain built-in types such as boolean.  The special formatting
rules for those types should apply to domains over them as well.
Per discussion.

While this is a bug fix, it's also a behavioral change that seems likely
to trip up some applications.  So no back-patch.

Pavel Stehule
diff --git a/src/backend/utils/adt/xml.c b/src/backend/utils/adt/xml.c
@@ -2001,6 +2001,12 @@ map_sql_value_to_xml_value(Datum value, Oid type, bool xml_escape_strings)
 		bool		isvarlena;
 		char	   *str;
 
+		/*
+		 * Flatten domains; the special-case treatments below should apply
+		 * to, eg, domains over boolean not just boolean.
+		 */
+		type = getBaseType(type);
+
 		/*
 		 * Special XSD formatting for some data types
 		 */
