Delete the temporary file used in buffered GiST build, after the build.

hlinnaka · hlinnaka · commit be02b16826ec · 2012-05-30T12:05:57.000+03:00
There were two bugs here: We forgot to call gistFreeBuildBuffers() function
at the end of build, and we passed interXact == true to BufFileCreateTemp,
so the file wasn't automatically cleaned up at end-of-transaction either.
diff --git a/src/backend/access/gist/gistbuild.c b/src/backend/access/gist/gistbuild.c
@@ -214,6 +214,7 @@ gistbuild(PG_FUNCTION_ARGS)
 	{
 		elog(DEBUG1, "all tuples processed, emptying buffers");
 		gistEmptyAllBuffers(&buildstate);
+		gistFreeBuildBuffers(buildstate.gfbb);
 	}
 
 	/* okay, all heap tuples are indexed */
diff --git a/src/backend/access/gist/gistbuildbuffers.c b/src/backend/access/gist/gistbuildbuffers.c
@@ -58,7 +58,7 @@ gistInitBuildBuffers(int pagesPerBuffer, int levelStep, int maxLevel)
 	 * Create a temporary file to hold buffer pages that are swapped out of
 	 * memory.
 	 */
-	gfbb->pfile = BufFileCreateTemp(true);
+	gfbb->pfile = BufFileCreateTemp(false);
 	gfbb->nFileBlocks = 0;
 
 	/* Initialize free page management. */

Original file line number	Diff line number	Diff line change
`@@ -214,6 +214,7 @@ gistbuild(PG_FUNCTION_ARGS)`
`214`	`214`	`{`
`215`	`215`	`elog(DEBUG1, "all tuples processed, emptying buffers");`
`216`	`216`	`gistEmptyAllBuffers(&buildstate);`
	`217`	`+ gistFreeBuildBuffers(buildstate.gfbb);`
`217`	`218`	`}`
`218`	`219`
`219`	`220`	`/* okay, all heap tuples are indexed */`