Add missing call to ConditionVariableCancelSleep().

robertmhaas · robertmhaas · commit c0348fd0e389 · 2024-07-22T10:02:31.000-04:00
After calling ConditionVariableSleep() or ConditionVariableTimedSleep() one or more times, code is supposed to call ConditionVariableCancelSleep() to remove itself from the waitlist. This code neglected to do so. As far as I know, that had no observable consequences, but let's make the code correct. Discussion: http://postgr.es/m/CA+TgmoYW8eR+KN6zhVH0sin7QH6AvENqw_bkN-bB4yLYKAnsew@mail.gmail.com
diff --git a/src/backend/postmaster/walsummarizer.c b/src/backend/postmaster/walsummarizer.c
@@ -682,6 +682,8 @@ WaitForWalSummarization(XLogRecPtr lsn, long timeout, XLogRecPtr *pending_lsn)
 									WAIT_EVENT_WAL_SUMMARY_READY);
 	}
 
+	ConditionVariableCancelSleep();
+
 	return summarized_lsn;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -682,6 +682,8 @@ WaitForWalSummarization(XLogRecPtr lsn, long timeout, XLogRecPtr *pending_lsn)`
`682`	`682`	`WAIT_EVENT_WAL_SUMMARY_READY);`
`683`	`683`	`}`
`684`	`684`
	`685`	`+ ConditionVariableCancelSleep();`
	`686`	`+`
`685`	`687`	`return summarized_lsn;`
`686`	`688`	`}`
`687`	`689`