Fix transaction-lifespan memory leak in xpath(). Report by Matt Magoffin,

tglsfdc · tglsfdc · commit c5f4b98faeeb · 2008-07-03T00:04:24.000Z
fix by Kris Jurka.
diff --git a/src/backend/utils/adt/xml.c b/src/backend/utils/adt/xml.c
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1996-2008, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * $PostgreSQL: pgsql/src/backend/utils/adt/xml.c,v 1.74 2008/05/12 00:00:51 alvherre Exp $
+ * $PostgreSQL: pgsql/src/backend/utils/adt/xml.c,v 1.75 2008/07/03 00:04:24 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -3160,6 +3160,7 @@ xml_xmlnodetoxmltype(xmlNodePtr cur)
 	{
 		str = xmlXPathCastNodeToString(cur);
 		result = (xmltype *) cstring_to_text((char *) str);
+		xmlFree(str);
 	}
 
 	return result;

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1996-2008, PostgreSQL Global Development Group`
`8`	`8`	`* Portions Copyright (c) 1994, Regents of the University of California`
`9`	`9`	`*`
`10`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/xml.c,v 1.74 2008/05/12 00:00:51 alvherre Exp $`
	`10`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/xml.c,v 1.75 2008/07/03 00:04:24 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -3160,6 +3160,7 @@ xml_xmlnodetoxmltype(xmlNodePtr cur)`
`3160`	`3160`	`{`
`3161`	`3161`	`str = xmlXPathCastNodeToString(cur);`
`3162`	`3162`	`result = (xmltype ) cstring_to_text((char ) str);`
	`3163`	`+ xmlFree(str);`
`3163`	`3164`	`}`
`3164`	`3165`
`3165`	`3166`	`return result;`