Remove dead code

petere · petere · commit ca89db5f9d0b · 2024-04-17T10:48:04.000+02:00
The configure check for HAVE_DECL_LLVMORCREGISTERPERF was removed by e9a9843, but some code guarded by it was left. (That commit removed the "register" calls but left the "unregister" calls.) That code cannot be reached anymore, so remove it. Reported-by: Heikki Linnakangas <hlinnaka@iki.fi> Discussion: https://www.postgresql.org/message-id/5539b16c-cff7-46d5-9621-c3fb6b549e9e@iki.fi
diff --git a/src/backend/jit/llvm/llvmjit.c b/src/backend/jit/llvm/llvmjit.c
@@ -1033,20 +1033,12 @@ llvm_shutdown(int code, Datum arg)
 
 		if (llvm_opt3_orc)
 		{
-#if defined(HAVE_DECL_LLVMORCREGISTERPERF) && HAVE_DECL_LLVMORCREGISTERPERF
-			if (jit_profiling_support)
-				LLVMOrcUnregisterPerf(llvm_opt3_orc);
-#endif
 			LLVMOrcDisposeInstance(llvm_opt3_orc);
 			llvm_opt3_orc = NULL;
 		}
 
 		if (llvm_opt0_orc)
 		{
-#if defined(HAVE_DECL_LLVMORCREGISTERPERF) && HAVE_DECL_LLVMORCREGISTERPERF
-			if (jit_profiling_support)
-				LLVMOrcUnregisterPerf(llvm_opt0_orc);
-#endif
 			LLVMOrcDisposeInstance(llvm_opt0_orc);
 			llvm_opt0_orc = NULL;
 		}

Original file line number	Diff line number	Diff line change
`@@ -1033,20 +1033,12 @@ llvm_shutdown(int code, Datum arg)`
`1033`	`1033`
`1034`	`1034`	`if (llvm_opt3_orc)`
`1035`	`1035`	`{`
`1036`		`-#if defined(HAVE_DECL_LLVMORCREGISTERPERF) && HAVE_DECL_LLVMORCREGISTERPERF`
`1037`		`- if (jit_profiling_support)`
`1038`		`- LLVMOrcUnregisterPerf(llvm_opt3_orc);`
`1039`		`-#endif`
`1040`	`1036`	`LLVMOrcDisposeInstance(llvm_opt3_orc);`
`1041`	`1037`	`llvm_opt3_orc = NULL;`
`1042`	`1038`	`}`
`1043`	`1039`
`1044`	`1040`	`if (llvm_opt0_orc)`
`1045`	`1041`	`{`
`1046`		`-#if defined(HAVE_DECL_LLVMORCREGISTERPERF) && HAVE_DECL_LLVMORCREGISTERPERF`
`1047`		`- if (jit_profiling_support)`
`1048`		`- LLVMOrcUnregisterPerf(llvm_opt0_orc);`
`1049`		`-#endif`
`1050`	`1042`	`LLVMOrcDisposeInstance(llvm_opt0_orc);`
`1051`	`1043`	`llvm_opt0_orc = NULL;`
`1052`	`1044`	`}`