Fix parent node of WCO expressions in partitioned tables.

anarazel · anarazel · commit d06aba240d24 · 2018-03-05T17:49:59.000-08:00
Since edd4473 WCO expressions of partitioned tables are initialized with the first subplan as parent. That's not correct, as the correct context is the ModifyTableState node. That's also what is used for RETURNING processing, initialized nearby. This appears not to cause any visible problems for in core code, but is problematic for in development patch. Discussion: https://postgr.es/m/20180303043818.tnvlo243bgy7una3@alap3.anarazel.de
diff --git a/src/backend/executor/execPartition.c b/src/backend/executor/execPartition.c
@@ -413,7 +413,7 @@ ExecInitPartitionInfo(ModifyTableState *mtstate,
 		{
 			WithCheckOption *wco = castNode(WithCheckOption, lfirst(ll));
 			ExprState  *wcoExpr = ExecInitQual(castNode(List, wco->qual),
-											   mtstate->mt_plans[0]);
+											   &mtstate->ps);
 
 			wcoExprs = lappend(wcoExprs, wcoExpr);
 		}

Original file line number	Diff line number	Diff line change
`@@ -413,7 +413,7 @@ ExecInitPartitionInfo(ModifyTableState *mtstate,`
`413`	`413`	`{`
`414`	`414`	`WithCheckOption *wco = castNode(WithCheckOption, lfirst(ll));`
`415`	`415`	`ExprState *wcoExpr = ExecInitQual(castNode(List, wco->qual),`
`416`		`- mtstate->mt_plans[0]);`
	`416`	`+ &mtstate->ps);`
`417`	`417`
`418`	`418`	`wcoExprs = lappend(wcoExprs, wcoExpr);`
`419`	`419`	`}`