pgbench: Correct log level of message output when socket wait method fails.

MasaoFujii · MasaoFujii · commit d33674708948 · 2021-09-29T21:46:56.000+09:00
The failure of socket wait method like "select()" doesn't terminate pgbench. So the log level of error message when that failure happens should be ERROR. But previously FATAL was used in that case. Back-patch to v13 where pgbench started using common logging API. Author: Yugo Nagata, Fabien COELHO Reviewed-by: Kyotaro Horiguchi, Fujii Masao Discussion: https://postgr.es/m/20210617005934.8bd37bf72efd5f1b38e6f482@sraoss.co.jp
diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
@@ -6784,7 +6784,7 @@ threadRun(void *arg)
 					continue;
 				}
 				/* must be something wrong */
-				pg_log_fatal("%s() failed: %m", SOCKET_WAIT_METHOD);
+				pg_log_error("%s() failed: %m", SOCKET_WAIT_METHOD);
 				goto done;
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -6784,7 +6784,7 @@ threadRun(void *arg)`
`6784`	`6784`	`continue;`
`6785`	`6785`	`}`
`6786`	`6786`	`/* must be something wrong */`
`6787`		`- pg_log_fatal("%s() failed: %m", SOCKET_WAIT_METHOD);`
	`6787`	`+ pg_log_error("%s() failed: %m", SOCKET_WAIT_METHOD);`
`6788`	`6788`	`goto done;`
`6789`	`6789`	`}`
`6790`	`6790`	`}`