Fix compiler warning and add some more comments

petere · petere · commit dc0400cc501e · 2017-04-06T11:18:13.000-04:00
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
@@ -5924,6 +5924,11 @@ ATExecAddIdentity(Relation rel, const char *colName,
 	return address;
 }
 
+/*
+ * ALTER TABLE ALTER COLUMN SET { GENERATED or sequence options }
+ *
+ * Return the address of the affected column.
+ */
 static ObjectAddress
 ATExecSetIdentity(Relation rel, const char *colName, Node *def, LOCKMODE lockmode)
 {
@@ -5992,13 +5997,20 @@ ATExecSetIdentity(Relation rel, const char *colName, Node *def, LOCKMODE lockmod
 		ObjectAddressSubSet(address, RelationRelationId,
 							RelationGetRelid(rel), attnum);
 	}
+	else
+		address = InvalidObjectAddress;
 
 	heap_freetuple(tuple);
 	heap_close(attrelation, RowExclusiveLock);
 
 	return address;
 }
 
+/*
+ * ALTER TABLE ALTER COLUMN DROP IDENTITY
+ *
+ * Return the address of the affected column.
+ */
 static ObjectAddress
 ATExecDropIdentity(Relation rel, const char *colName, bool missing_ok, LOCKMODE lockmode)
 {

Original file line number	Diff line number	Diff line change
`@@ -5924,6 +5924,11 @@ ATExecAddIdentity(Relation rel, const char *colName,`
`5924`	`5924`	`return address;`
`5925`	`5925`	`}`
`5926`	`5926`
	`5927`	`+/*`
	`5928`	`+ * ALTER TABLE ALTER COLUMN SET { GENERATED or sequence options }`
	`5929`	`+ *`
	`5930`	`+ * Return the address of the affected column.`
	`5931`	`+ */`
`5927`	`5932`	`static ObjectAddress`
`5928`	`5933`	`ATExecSetIdentity(Relation rel, const char colName, Node def, LOCKMODE lockmode)`
`5929`	`5934`	`{`
`@@ -5992,13 +5997,20 @@ ATExecSetIdentity(Relation rel, const char colName, Node def, LOCKMODE lockmod`
`5992`	`5997`	`ObjectAddressSubSet(address, RelationRelationId,`
`5993`	`5998`	`RelationGetRelid(rel), attnum);`
`5994`	`5999`	`}`
	`6000`	`+ else`
	`6001`	`+ address = InvalidObjectAddress;`
`5995`	`6002`
`5996`	`6003`	`heap_freetuple(tuple);`
`5997`	`6004`	`heap_close(attrelation, RowExclusiveLock);`
`5998`	`6005`
`5999`	`6006`	`return address;`
`6000`	`6007`	`}`
`6001`	`6008`
	`6009`	`+/*`
	`6010`	`+ * ALTER TABLE ALTER COLUMN DROP IDENTITY`
	`6011`	`+ *`
	`6012`	`+ * Return the address of the affected column.`
	`6013`	`+ */`
`6002`	`6014`	`static ObjectAddress`
`6003`	`6015`	`ATExecDropIdentity(Relation rel, const char *colName, bool missing_ok, LOCKMODE lockmode)`
`6004`	`6016`	`{`