Use [FLEXIBLE_ARRAY_MEMBER] not [1] in MultiSortSupportData.

tglsfdc · tglsfdc · commit dde7fb7836c7 · 2019-04-15T19:32:44.000-04:00
This struct seems to have not gotten the word about preferred
coding style for variable-length arrays.
diff --git a/src/include/statistics/extended_stats_internal.h b/src/include/statistics/extended_stats_internal.h
@@ -43,8 +43,9 @@ typedef struct DimensionInfo
 /* multi-sort */
 typedef struct MultiSortSupportData
 {
-	int			ndims;			/* number of dimensions supported by the */
-	SortSupportData ssup[1];	/* sort support data for each dimension */
+	int			ndims;			/* number of dimensions */
+	/* sort support data for each dimension: */
+	SortSupportData ssup[FLEXIBLE_ARRAY_MEMBER];
 } MultiSortSupportData;
 
 typedef MultiSortSupportData *MultiSortSupport;
