In dsm_impl_windows, don't error out when the segment already exists.

robertmhaas · robertmhaas · commit e5158613676d · 2013-10-14T11:48:49.000-04:00
This is the behavior of the other implementations, and the behavior
expected by the callers of this function.

Amit Kapila
diff --git a/src/backend/storage/ipc/dsm_impl.c b/src/backend/storage/ipc/dsm_impl.c
@@ -694,10 +694,6 @@ dsm_impl_windows(dsm_op op, dsm_handle handle, uint64 request_size,
 			 * modified.
 			 */
 			CloseHandle(hmap);
-			ereport(elevel,
-					(errcode_for_dynamic_shared_memory(),
-					 errmsg("could not open shared memory segment \"%s\": %m",
-						name)));
 			return false;
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -694,10 +694,6 @@ dsm_impl_windows(dsm_op op, dsm_handle handle, uint64 request_size,`
`694`	`694`	`* modified.`
`695`	`695`	`*/`
`696`	`696`	`CloseHandle(hmap);`
`697`		`- ereport(elevel,`
`698`		`- (errcode_for_dynamic_shared_memory(),`
`699`		`- errmsg("could not open shared memory segment \"%s\": %m",`
`700`		`- name)));`
`701`	`697`	`return false;`
`702`	`698`	`}`
`703`	`699`	`}`