After PageSetAllVisible, use MarkBufferDirty.

robertmhaas · robertmhaas · commit e93c0b820f03 · 2012-04-18T10:49:37.000-04:00
Previously, we used SetBufferCommitInfoNeedsSave, but that's really
intended for dirty-marks we can theoretically afford to lose, such as
hint bits.  As for 9.2, the PD_ALL_VISIBLE mustn't be lost in this
way, since we could then end up with a heap page that isn't
all-visible and a visibility map page that is all visible, causing
index-only scans to return wrong answers.
diff --git a/src/backend/commands/vacuumlazy.c b/src/backend/commands/vacuumlazy.c
@@ -603,7 +603,7 @@ lazy_scan_heap(Relation onerel, LVRelStats *vacrelstats,
 			if (!PageIsAllVisible(page))
 			{
 				PageSetAllVisible(page);
-				SetBufferCommitInfoNeedsSave(buf);
+				MarkBufferDirty(buf);
 			}
 
 			LockBuffer(buf, BUFFER_LOCK_UNLOCK);
@@ -838,7 +838,7 @@ lazy_scan_heap(Relation onerel, LVRelStats *vacrelstats,
 		if (!PageIsAllVisible(page) && all_visible)
 		{
 			PageSetAllVisible(page);
-			SetBufferCommitInfoNeedsSave(buf);
+			MarkBufferDirty(buf);
 		}
 
 		/*

Original file line number	Diff line number	Diff line change
`@@ -603,7 +603,7 @@ lazy_scan_heap(Relation onerel, LVRelStats *vacrelstats,`
`603`	`603`	`if (!PageIsAllVisible(page))`
`604`	`604`	`{`
`605`	`605`	`PageSetAllVisible(page);`
`606`		`- SetBufferCommitInfoNeedsSave(buf);`
	`606`	`+ MarkBufferDirty(buf);`
`607`	`607`	`}`
`608`	`608`
`609`	`609`	`LockBuffer(buf, BUFFER_LOCK_UNLOCK);`
`@@ -838,7 +838,7 @@ lazy_scan_heap(Relation onerel, LVRelStats *vacrelstats,`
`838`	`838`	`if (!PageIsAllVisible(page) && all_visible)`
`839`	`839`	`{`
`840`	`840`	`PageSetAllVisible(page);`
`841`		`- SetBufferCommitInfoNeedsSave(buf);`
	`841`	`+ MarkBufferDirty(buf);`
`842`	`842`	`}`
`843`	`843`
`844`	`844`	`/*`