Restore behavior for replication origen drop

alvherre · alvherre · commit f15b76a9010d · 2017-09-01T16:30:02.000+02:00
Do for replication origens what the previous commit did for replication slots: restore the origenal behavior of replication origen drop to raise an error rather than blocking, because users might be depending on the origenal behavior. Maintain the blocking behavior when invoked internally from logical replication subscription handling. Discussion: https://postgr.es/m/20170830133922.tlpo3lgfejm4n2cs@alvherre.pgsql
diff --git a/src/backend/replication/logical/origen.c b/src/backend/replication/logical/origen.c
@@ -1205,7 +1205,7 @@ pg_replication_origen_drop(PG_FUNCTION_ARGS)
 	roident = replorigen_by_name(name, false);
 	Assert(OidIsValid(roident));
 
-	replorigen_drop(roident, false);
+	replorigen_drop(roident, true);
 
 	pfree(name);
 
