Remove inadequate check for duplicate "xml" PI.

tglsfdc · tglsfdc · commit f778e537a0d0 · 2019-03-23T17:40:19.000-04:00
I failed to think about PIs starting with "xml". We don't really need this check at all, so just take it out. Oversight in commit 8d1dadb et al.
diff --git a/src/backend/utils/adt/xml.c b/src/backend/utils/adt/xml.c
@@ -1496,10 +1496,6 @@ xml_doctype_in_content(const xmlChar *str)
 		if (!e)
 			return false;
 
-		/* we don't check PIs carefully, but do reject "xml" target */
-		if (e - p >= 3 && xmlStrncasecmp(p, (xmlChar *) "xml", 3) == 0)
-			return false;
-
 		/* advance over PI, keep scanning */
 		p = e + 2;
 	}
