Handle alphanumeric characters in matching GUC names

danielgustafsson · danielgustafsson · commit f81855171f95 · 2024-10-24T15:20:16.000+02:00
The check for whether all GUCs are present in the sample config file used the POSIX character class :alpha: which corresponds to alphabet and not alphanumeric. Since GUC names can contain digits as well we need to use the :alnum: character class instead. Author: Daniel Gustafsson <daniel@yesql.se> Discussion: https://postgr.es/m/2CB04559-B1D8-4558-B6F0-8F09093D629F@yesql.se
diff --git a/src/test/modules/test_misc/t/003_check_guc.pl b/src/test/modules/test_misc/t/003_check_guc.pl
@@ -56,7 +56,7 @@
 	# file.
 	# - Valid configuration options are followed immediately by " = ",
 	# with one space before and after the equal sign.
-	if ($line =~ m/^#?([_[:alpha:]]+) = .*/)
+	if ($line =~ m/^#?([_[:alnum:]]+) = .*/)
 	{
 		# Lower-case conversion matters for some of the GUCs.
 		my $param_name = lc($1);

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@`
`56`	`56`	`# file.`
`57`	`57`	`# - Valid configuration options are followed immediately by " = ",`
`58`	`58`	`# with one space before and after the equal sign.`
`59`		`- if ($line =~ m/^#?([_[:alpha:]]+) = .*/)`
	`59`	`+ if ($line =~ m/^#?([_[:alnum:]]+) = .*/)`
`60`	`60`	`{`
`61`	`61`	`# Lower-case conversion matters for some of the GUCs.`
`62`	`62`	`my $param_name = lc($1);`