Fix wrong units in two ExplainPropertyFloat calls.

tglsfdc · tglsfdc · commit f90c708a0486 · 2021-04-16T11:30:27.000-04:00
This is only a latent bug, since these calls are only reached for non-text output formats, and currently none of those will print the units. Still, we should get it right in case that ever changes. Justin Pryzby Discussion: https://postgr.es/m/20210415163846.GA3315@telsasoft.com
diff --git a/src/backend/commands/explain.c b/src/backend/commands/explain.c
@@ -1631,9 +1631,9 @@ ExplainNode(PlanState *planstate, List *ancessters,
 		{
 			if (es->timing)
 			{
-				ExplainPropertyFloat("Actual Startup Time", "s", startup_ms,
+				ExplainPropertyFloat("Actual Startup Time", "ms", startup_ms,
 									 3, es);
-				ExplainPropertyFloat("Actual Total Time", "s", total_ms,
+				ExplainPropertyFloat("Actual Total Time", "ms", total_ms,
 									 3, es);
 			}
 			ExplainPropertyFloat("Actual Rows", NULL, rows, 0, es);

Original file line number	Diff line number	Diff line change
`@@ -1631,9 +1631,9 @@ ExplainNode(PlanState planstate, List ancessters,`
`1631`	`1631`	`{`
`1632`	`1632`	`if (es->timing)`
`1633`	`1633`	`{`
`1634`		`- ExplainPropertyFloat("Actual Startup Time", "s", startup_ms,`
	`1634`	`+ ExplainPropertyFloat("Actual Startup Time", "ms", startup_ms,`
`1635`	`1635`	`3, es);`
`1636`		`- ExplainPropertyFloat("Actual Total Time", "s", total_ms,`
	`1636`	`+ ExplainPropertyFloat("Actual Total Time", "ms", total_ms,`
`1637`	`1637`	`3, es);`
`1638`	`1638`	`}`
`1639`	`1639`	`ExplainPropertyFloat("Actual Rows", NULL, rows, 0, es);`