Improve logic in PostgresVersion.pm

adunstan · adunstan · commit fa26eba221a9 · 2021-04-27T08:21:15.000-04:00
Handle the situation where perl swaps the order of operands of
the comparison operator. See `perldoc overload` for details:

The third argument is set to TRUE if (and only if) the two
operands have been swapped. Perl may do this to ensure that the
first argument ($self) is an object implementing the overloaded
operation, in line with general object calling conventions.
diff --git a/src/test/perl/PostgresVersion.pm b/src/test/perl/PostgresVersion.pm
@@ -110,10 +110,12 @@ sub new
 #
 sub _version_cmp
 {
-	my ($a, $b) = @_;
+	my ($a, $b, $swapped) = @_;
 
 	$b = __PACKAGE__->new($b) unless blessed($b);
 
+	($a, $b) = ($b, $a) if $swapped;
+
 	my ($an, $bn) = ($a->{num}, $b->{num});
 
 	for (my $idx = 0;; $idx++)

Original file line number	Diff line number	Diff line change
`@@ -110,10 +110,12 @@ sub new`
`110`	`110`	`#`
`111`	`111`	`sub _version_cmp`
`112`	`112`	`{`
`113`		`- my ($a, $b) = @_;`
	`113`	`+ my ($a, $b, $swapped) = @_;`
`114`	`114`
`115`	`115`	`$b = __PACKAGE__->new($b) unless blessed($b);`
`116`	`116`
	`117`	`+ ($a, $b) = ($b, $a) if $swapped;`
	`118`	`+`
`117`	`119`	`my ($an, $bn) = ($a->{num}, $b->{num});`
`118`	`120`
`119`	`121`	`for (my $idx = 0;; $idx++)`