Remove redundant incomplete split assertion.

petergeoghegan · petergeoghegan · commit fc3100112395 · 2020-01-05T17:42:13.000-08:00
The fastpath insert optimization's incomplete split flag Assert() is
redundant.  We'll reach the more general Assert() within
_bt_findinsertloc() in all cases. (Besides, Assert()'ing that the
rightmost page doesn't have the flag set never made much sense.)
diff --git a/src/backend/access/nbtree/nbtinsert.c b/src/backend/access/nbtree/nbtinsert.c
@@ -179,11 +179,6 @@ _bt_doinsert(Relation rel, IndexTuple itup,
 				PageGetMaxOffsetNumber(page) >= P_FIRSTDATAKEY(lpageop) &&
 				_bt_compare(rel, itup_key, page, P_FIRSTDATAKEY(lpageop)) > 0)
 			{
-				/*
-				 * The right-most block should never have an incomplete split.
-				 * But be paranoid and check for it anyway.
-				 */
-				Assert(!P_INCOMPLETE_SPLIT(lpageop));
 				fastpath = true;
 			}
 			else

Original file line number	Diff line number	Diff line change
`@@ -179,11 +179,6 @@ _bt_doinsert(Relation rel, IndexTuple itup,`
`179`	`179`	`PageGetMaxOffsetNumber(page) >= P_FIRSTDATAKEY(lpageop) &&`
`180`	`180`	`_bt_compare(rel, itup_key, page, P_FIRSTDATAKEY(lpageop)) > 0)`
`181`	`181`	`{`
`182`		`- /*`
`183`		`- * The right-most block should never have an incomplete split.`
`184`		`- * But be paranoid and check for it anyway.`
`185`		`- */`
`186`		`- Assert(!P_INCOMPLETE_SPLIT(lpageop));`
`187`	`182`	`fastpath = true;`
`188`	`183`	`}`
`189`	`184`	`else`