Fix ancient compiler warnings and typos in !HAVE_SYMLINK code

petere · petere · commit 018923ccc1a6 · 2018-12-22T07:25:20.000+01:00
This has never been correct since this code was introduced.
diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
@@ -2918,7 +2918,7 @@ create_xlog_or_symlink(void)
 			exit_nicely();
 		}
 #else
-		fprintf(stderr, _("%s: symlinks are not supported on this platform"));
+		fprintf(stderr, _("%s: symlinks are not supported on this platform\n"), progname);
 		exit_nicely();
 #endif
 	}
diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c
@@ -2523,7 +2523,7 @@ main(int argc, char **argv)
 			disconnect_and_exit(1);
 		}
 #else
-		fprintf(stderr, _("%s: symlinks are not supported on this platform\n"));
+		fprintf(stderr, _("%s: symlinks are not supported on this platform\n"), progname);
 		disconnect_and_exit(1);
 #endif
 		free(linkloc);

Original file line number	Diff line number	Diff line change
`@@ -2918,7 +2918,7 @@ create_xlog_or_symlink(void)`
`2918`	`2918`	`exit_nicely();`
`2919`	`2919`	`}`
`2920`	`2920`	`#else`
`2921`		`- fprintf(stderr, _("%s: symlinks are not supported on this platform"));`
	`2921`	`+ fprintf(stderr, _("%s: symlinks are not supported on this platform\n"), progname);`
`2922`	`2922`	`exit_nicely();`
`2923`	`2923`	`#endif`
`2924`	`2924`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2523,7 +2523,7 @@ main(int argc, char **argv)`
`2523`	`2523`	`disconnect_and_exit(1);`
`2524`	`2524`	`}`
`2525`	`2525`	`#else`
`2526`		`- fprintf(stderr, _("%s: symlinks are not supported on this platform\n"));`
	`2526`	`+ fprintf(stderr, _("%s: symlinks are not supported on this platform\n"), progname);`
`2527`	`2527`	`disconnect_and_exit(1);`
`2528`	`2528`	`#endif`
`2529`	`2529`	`free(linkloc);`