Add missing check for malloc failure in plpgsql_extra_checks_check_hook().

tglsfdc · tglsfdc · commit 1fe1204e87c4 · 2016-06-20T15:36:54.000-04:00
Per report from Andreas Seltenreich.  Back-patch to affected versions.

Report: &lt;874m8nn0hv.fsf@elite.ansel.ydns.eu&gt;
diff --git a/src/pl/plpgsql/src/pl_handler.c b/src/pl/plpgsql/src/pl_handler.c
@@ -110,6 +110,8 @@ plpgsql_extra_checks_check_hook(char **newvalue, void **extra, GucSource source)
 	}
 
 	myextra = (int *) malloc(sizeof(int));
+	if (!myextra)
+		return false;
 	*myextra = extrachecks;
 	*extra = (void *) myextra;
 

Original file line number	Diff line number	Diff line change
`@@ -110,6 +110,8 @@ plpgsql_extra_checks_check_hook(char newvalue, void extra, GucSource source)`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`myextra = (int *) malloc(sizeof(int));`
	`113`	`+ if (!myextra)`
	`114`	`+ return false;`
`113`	`115`	`*myextra = extrachecks;`
`114`	`116`	`extra = (void ) myextra;`
`115`	`117`