Avoid assuming that we know the spelling of getopt_long's error messages.

tglsfdc · tglsfdc · commit 251f57460f12 · 2019-01-17T19:31:27.000-05:00
I've had enough of "fixing" this test case. Whatever value it has is limited to verifying that pgbench fails for an unrecognized switch, and we don't need to assume anything about what getopt_long prints in order to do that. Discussion: https://postgr.es/m/9427.1547701450@sss.pgh.pa.us
diff --git a/src/bin/pgbench/t/002_pgbench_no_server.pl b/src/bin/pgbench/t/002_pgbench_no_server.pl
@@ -66,7 +66,7 @@ sub pgbench_scripts
 	[
 		'bad option',
 		'-h home -p 5432 -U calvin -d --bad-option',
-		[ qr{(unrecognized|illegal) option}, qr{--help.*more information} ]
+		[qr{--help.*more information}]
 	],
 	[
 		'no file',

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ sub pgbench_scripts`
`66`	`66`	`[`
`67`	`67`	`'bad option',`
`68`	`68`	`'-h home -p 5432 -U calvin -d --bad-option',`
`69`		`- [ qr{(unrecognized\|illegal) option}, qr{--help.*more information} ]`
	`69`	`+ [qr{--help.*more information}]`
`70`	`70`	`],`
`71`	`71`	`[`
`72`	`72`	`'no file',`