Fix the RTE_NAMEDTUPLESTORE case in get_rte_attribute_is_dropped().

kgrittn · kgrittn · commit 255efa241f46 · 2017-04-06T17:32:53.000-05:00
Problems pointed out by Andres Freund and Thomas Munro.
diff --git a/src/backend/parser/parse_relation.c b/src/backend/parser/parse_relation.c
@@ -2891,12 +2891,12 @@ get_rte_attribute_is_dropped(RangeTblEntry *rte, AttrNumber attnum)
 				Assert(rte->enrname);
 
 				/*
-				 * We checked when we loaded ctecoltypes for the tuplestore
-				 * that InvalidOid was only used for dropped columns, so it is
-				 * safe to count on that here.
+				 * We checked when we loaded coltypes for the tuplestore that
+				 * InvalidOid was only used for dropped columns, so it is safe
+				 * to count on that here.
 				 */
 				result =
-					(list_nth(rte->coltypes, attnum - 1) != InvalidOid);
+					((list_nth_oid(rte->coltypes, attnum - 1) == InvalidOid));
 			}
 			break;
 		case RTE_JOIN:
