Content-Length: 277490 | pFad | http://github.com/postgrespro/postgres_cluster/commit/331f8c311b7ba4b24158071ab2fb2e07bb8377b0

67 Remove test for COMMENT ON DATABASE · postgrespro/postgres_cluster@331f8c3 · GitHub
Skip to content

Commit 331f8c3

Browse files
committed
Remove test for COMMENT ON DATABASE
Our current DDL only allows a database name to be specified in COMMENT ON DATABASE, which Andrew Dunstan reports to make this test fail on the buildfarm. Remove the line until we gain a DDL command that allows the current database to be operated on without having the specify it by name. Backpatch to 9.5, where these tests appeared. Discussion: https://postgr.es/m/e6084b89-07a7-7e57-51ee-d7b8fc9ec864@2ndQuadrant.com
1 parent e630faa commit 331f8c3

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

src/test/modules/test_ddl_deparse/expected/comment_on.out

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,3 @@ COMMENT ON TRIGGER trigger_1 ON datatype_table IS 'TRIGGER test';
2121
NOTICE: DDL test: type simple, tag COMMENT
2222
COMMENT ON RULE rule_1 IS 'RULE test';
2323
NOTICE: DDL test: type simple, tag COMMENT
24-
-- should not fire
25-
COMMENT ON DATABASE contrib_regression IS 'contrib regression';

src/test/modules/test_ddl_deparse/sql/comment_on.sql

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,3 @@ COMMENT ON VIEW datatype_view IS 'This is a view';
1212
COMMENT ON FUNCTION c_function_test() IS 'FUNCTION test';
1313
COMMENT ON TRIGGER trigger_1 ON datatype_table IS 'TRIGGER test';
1414
COMMENT ON RULE rule_1 IS 'RULE test';
15-
16-
-- should not fire
17-
COMMENT ON DATABASE contrib_regression IS 'contrib regression';

0 commit comments

Comments
 (0)








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/postgrespro/postgres_cluster/commit/331f8c311b7ba4b24158071ab2fb2e07bb8377b0

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy