Fix a potential binarith->boolean result truncation in raftable.

kvap · kvap · commit 3e6d19ca6913 · 2016-06-15T16:16:11.000+03:00
diff --git a/contrib/raftable/raftable.c b/contrib/raftable/raftable.c
@@ -86,15 +86,15 @@ static bool poll_until_writable(int sock, int timeout_ms)
 	struct pollfd pfd = {sock, POLLOUT, 0};
 	int r = poll(&pfd, 1, timeout_ms);
 	if (r != 1) return false;
-	return pfd.revents & POLLOUT;
+	return (pfd.revents & POLLOUT) != 0;
 }
 
 static bool poll_until_readable(int sock, int timeout_ms)
 {
 	struct pollfd pfd = {sock, POLLIN, 0};
 	int r = poll(&pfd, 1, timeout_ms);
 	if (r != 1) return false;
-	return pfd.revents & POLLIN;
+	return (pfd.revents & POLLIN) != 0;
 }
 
 static long msec(TimestampTz timer)

Original file line number	Diff line number	Diff line change
`@@ -86,15 +86,15 @@ static bool poll_until_writable(int sock, int timeout_ms)`
`86`	`86`	`struct pollfd pfd = {sock, POLLOUT, 0};`
`87`	`87`	`int r = poll(&pfd, 1, timeout_ms);`
`88`	`88`	`if (r != 1) return false;`
`89`		`- return pfd.revents & POLLOUT;`
	`89`	`+ return (pfd.revents & POLLOUT) != 0;`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`static bool poll_until_readable(int sock, int timeout_ms)`
`93`	`93`	`{`
`94`	`94`	`struct pollfd pfd = {sock, POLLIN, 0};`
`95`	`95`	`int r = poll(&pfd, 1, timeout_ms);`
`96`	`96`	`if (r != 1) return false;`
`97`		`- return pfd.revents & POLLIN;`
	`97`	`+ return (pfd.revents & POLLIN) != 0;`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`static long msec(TimestampTz timer)`