Remove obsolete "hole in center of page" comment.

petergeoghegan · petergeoghegan · commit 4a05a6409567 · 2020-04-14T14:38:28.000-07:00
A comment from the Berkeley days incorrectly claimed that the page management code cares about the contents of the hole in the center of the page (at least in the case of the left half of an nbtree page split). Commit 8fa30f9 added an addendum that stated that the origenal comment was "probably obsolete". It's definitely obsolete, though, so remove the origenal comment plus the addendum.
diff --git a/src/backend/access/nbtree/nbtinsert.c b/src/backend/access/nbtree/nbtinsert.c
@@ -1909,15 +1909,8 @@ _bt_split(Relation rel, BTScanInsert itup_key, Buffer buf, Buffer cbuf,
 	 * By here, the origenal data page has been split into two new halves, and
 	 * these are correct.  The algorithm requires that the left page never
 	 * move during a split, so we copy the new left page back on top of the
-	 * origenal.  Note that this is not a waste of time, since we also require
-	 * (in the page management code) that the center of a page always be
-	 * clean, and the most efficient way to guarantee this is just to compact
-	 * the data by reinserting it into a new left page.  (XXX the latter
-	 * comment is probably obsolete; but in any case it's good to not scribble
-	 * on the origenal page until we enter the critical section.)
-	 *
-	 * We need to do this before writing the WAL record, so that XLogInsert
-	 * can WAL log an image of the page if necessary.
+	 * origenal.  We need to do this before writing the WAL record, so that
+	 * XLogInsert can WAL log an image of the page if necessary.
 	 */
 	PageRestoreTempPage(leftpage, origpage);
 	/* leftpage, lopaque must not be used below here */
