Remove incorrect use of VARSIZE() on a toasted datum. We can just remove it

tglsfdc · tglsfdc · commit 56b7695cf551 · 2007-10-11T18:19:58.000Z
instead of fix it, since once we've set toast_action[i] to 'p' it no longer
matters what toast_sizes[i] is.  Greg Stark
diff --git a/src/backend/access/heap/tuptoaster.c b/src/backend/access/heap/tuptoaster.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/access/heap/tuptoaster.c,v 1.77 2007/10/01 16:25:56 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/access/heap/tuptoaster.c,v 1.78 2007/10/11 18:19:58 tgl Exp $
  *
  *
  * INTERFACE ROUTINES
@@ -811,9 +811,7 @@ toast_insert_or_update(Relation rel, HeapTuple newtup, HeapTuple oldtup,
 										   use_wal, use_fsm);
 		if (toast_free[i])
 			pfree(DatumGetPointer(old_value));
-
 		toast_free[i] = true;
-		toast_sizes[i] = VARSIZE(toast_values[i]);
 
 		need_change = true;
 		need_free = true;

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/access/heap/tuptoaster.c,v 1.77 2007/10/01 16:25:56 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/access/heap/tuptoaster.c,v 1.78 2007/10/11 18:19:58 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*`
`14`	`14`	`* INTERFACE ROUTINES`
`@@ -811,9 +811,7 @@ toast_insert_or_update(Relation rel, HeapTuple newtup, HeapTuple oldtup,`
`811`	`811`	`use_wal, use_fsm);`
`812`	`812`	`if (toast_free[i])`
`813`	`813`	`pfree(DatumGetPointer(old_value));`
`814`		`-`
`815`	`814`	`toast_free[i] = true;`
`816`		`- toast_sizes[i] = VARSIZE(toast_values[i]);`
`817`	`815`
`818`	`816`	`need_change = true;`
`819`	`817`	`need_free = true;`