Make error message of pageinspect more consistent for raw page inputs

michaelpq · michaelpq · commit 59eb12c9c5a5 · 2018-07-29T23:50:35.000+09:00
There is a copy-paste error from bt_page_items() which got into bt_page_items_bytea(). A second message in get_raw_page_internal() was inconsistent with all the other sub-modules. Author: Ashutosh Sharma Discussion: https://postgr.es/m/CAE9k0PnZuZ3PVXSyQY91-53E8JKFcaSyknFqqU43r9MabKSYZA@mail.gmail.com
diff --git a/contrib/pageinspect/btreefuncs.c b/contrib/pageinspect/btreefuncs.c
@@ -429,7 +429,7 @@ bt_page_items_bytea(PG_FUNCTION_ARGS)
 	if (!superuser())
 		ereport(ERROR,
 				(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
-				 (errmsg("must be superuser to use pageinspect functions"))));
+				 (errmsg("must be superuser to use raw page functions"))));
 
 	if (SRF_IS_FIRSTCALL())
 	{
diff --git a/contrib/pageinspect/rawpage.c b/contrib/pageinspect/rawpage.c
@@ -102,7 +102,7 @@ get_raw_page_internal(text *relname, ForkNumber forknum, BlockNumber blkno)
 	if (!superuser())
 		ereport(ERROR,
 				(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
-				 (errmsg("must be superuser to use raw functions"))));
+				 (errmsg("must be superuser to use raw page functions"))));
 
 	relrv = makeRangeVarFromNameList(textToQualifiedNameList(relname));
 	rel = relation_openrv(relrv, AccessShareLock);

Original file line number	Diff line number	Diff line change
`@@ -429,7 +429,7 @@ bt_page_items_bytea(PG_FUNCTION_ARGS)`
`429`	`429`	`if (!superuser())`
`430`	`430`	`ereport(ERROR,`
`431`	`431`	`(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),`
`432`		`- (errmsg("must be superuser to use pageinspect functions"))));`
	`432`	`+ (errmsg("must be superuser to use raw page functions"))));`
`433`	`433`
`434`	`434`	`if (SRF_IS_FIRSTCALL())`
`435`	`435`	`{`