Add opaque declaration of HTAB to tqual.h.

kgrittn · kgrittn · commit 604e99396de0 · 2015-06-27T09:55:06.000-05:00
Commit b89e151 added the ResolveCminCmaxDuringDecoding declaration to tqual.h, which uses an HTAB parameter, without declaring HTAB. It accidentally fails to fail to build with current sources because a declaration happens to be included, directly or indirectly, in all source files that currently use tqual.h before tqual.h is first included, but we shouldn't count on that. Since an opaque declaration is enough here, just use that, as was done in snapmgr.h. Backpatch to 9.4, where the HTAB reference was added to tqual.h.
diff --git a/src/include/utils/tqual.h b/src/include/utils/tqual.h
@@ -94,6 +94,7 @@ extern bool HeapTupleHeaderIsOnlyLocked(HeapTupleHeader tuple);
  * To avoid leaking too much knowledge about reorderbuffer implementation
  * details this is implemented in reorderbuffer.c not tqual.c.
  */
+struct HTAB;
 extern bool ResolveCminCmaxDuringDecoding(struct HTAB *tuplecid_data,
 							  Snapshot snapshot,
 							  HeapTuple htup,
