Fix zic for Windows.

tglsfdc · tglsfdc · commit 6d257e732b35 · 2016-03-29T10:40:08.000-04:00
The new coding of dolink() is dependent on link() returning an on-point
errno when it fails; but the quick-hack implementation of link() that
we'd put in for Windows didn't bother with setting errno.  Fix that.

Analysis and patch by Christian Ullrich.
diff --git a/src/timezone/zic.c b/src/timezone/zic.c
@@ -3485,7 +3485,10 @@ int
 link(const char *oldpath, const char *newpath)
 {
 	if (!CopyFile(oldpath, newpath, false))
+	{
+		_dosmaperr(GetLastError());
 		return -1;
+	}
 	return 0;
 }
 #endif

Original file line number	Diff line number	Diff line change
`@@ -3485,7 +3485,10 @@ int`
`3485`	`3485`	`link(const char oldpath, const char newpath)`
`3486`	`3486`	`{`
`3487`	`3487`	`if (!CopyFile(oldpath, newpath, false))`
	`3488`	`+ {`
	`3489`	`+ _dosmaperr(GetLastError());`
`3488`	`3490`	`return -1;`
	`3491`	`+ }`
`3489`	`3492`	`return 0;`
`3490`	`3493`	`}`
`3491`	`3494`	`#endif`