Fix bug where pg_receivexlog goes into busy loop if -s option is set to 0.

MasaoFujii · MasaoFujii · commit 78493b716802 · 2014-07-24T15:25:26.000+09:00
The problem is that pg_receivexlog calls select(2) with timeout=0 and goes into busy loop when --status-interval option is set to 0. This bug was introduced by the commit, 74cbe96. Per report from Sawada Masahiko
diff --git a/src/bin/pg_basebackup/receivelog.c b/src/bin/pg_basebackup/receivelog.c
@@ -1094,7 +1094,7 @@ CopyStreamReceive(PGconn *conn, long timeout, char **buffer)
 		 * No data available. Wait for some to appear, but not longer than
 		 * the specified timeout, so that we can ping the server.
 		 */
-		if (timeout > 0)
+		if (timeout != 0)
 		{
 			int		ret;
 

Original file line number	Diff line number	Diff line change
`@@ -1094,7 +1094,7 @@ CopyStreamReceive(PGconn conn, long timeout, char *buffer)`
`1094`	`1094`	`* No data available. Wait for some to appear, but not longer than`
`1095`	`1095`	`* the specified timeout, so that we can ping the server.`
`1096`	`1096`	`*/`
`1097`		`- if (timeout > 0)`
	`1097`	`+ if (timeout != 0)`
`1098`	`1098`	`{`
`1099`	`1099`	`int ret;`
`1100`	`1100`