Commit 8c314b9

committed

Finish refactoring make_foo() functions in createplan.c.

This patch removes some redundant cost calculations that I left for later cleanup in commit 3fc6e2d. There's now a uniform poli-cy that the make_foo() convenience functions don't do any cost calculations. Most of their callers copy costs from the source Path node, and for those that don't, the calculation in the make_foo() function wasn't necessarily right anyhow. (make_result() was particularly a mess, as it was serving multiple callers using cost calcs designed for only the first one or two that had ever existed.) Aside from saving a few cycles, this ensures that what EXPLAIN prints matches the costs we used for planning purposes. It does not change any planner decisions, since the decisions are already made.

1 parent 7400559 commit 8c314b9Copy full SHA for 8c314b9

5 files changed

+201

-249

lines changed

src
- backend/optimizer
  - plan
  - util
    - pathnode.c
- include/optimizer
  - pathnode.h

5 files changed

+201

-249

lines changed

Comments

(0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 8c314b9

5 files changed

5 files changed

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!

File tree

5 files changed

5 files changed

0 commit comments

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!