Content-Length: 264183 | pFad | http://github.com/postgrespro/postgres_cluster/commit/95b52351fe966c93791462274dfa7af7e50d2da1

87 Remove obsolete comment. · postgrespro/postgres_cluster@95b5235 · GitHub
Skip to content

Commit 95b5235

Browse files
committed
Remove obsolete comment.
Commit 8b304b8 removed replacement selection, but left behind this comment text. The optimization to which the comment refers is not relevant without replacement selection, because if we had so few tuples as to require only one tape, we would have just completed the sort in memory. Peter Geoghegan Discussion: http://postgr.es/m/CAH2-WznqupLA8CMjp+vqzoe0yXu0DYYbQSNZxmgN76tLnAOZ_w@mail.gmail.com
1 parent d329dc2 commit 95b5235

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

src/backend/utils/sort/tuplesort.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2459,11 +2459,6 @@ mergeruns(Tuplesortstate *state)
24592459
* Use all the remaining memory we have available for read buffers among
24602460
* the input tapes.
24612461
*
2462-
* We do this only after checking for the case that we produced only one
2463-
* initial run, because there is no need to use a large read buffer when
2464-
* we're reading from a single tape. With one tape, the I/O pattern will
2465-
* be the same regardless of the buffer size.
2466-
*
24672462
* We don't try to "rebalance" the memory among tapes, when we start a new
24682463
* merge phase, even if some tapes are inactive in the new phase. That
24692464
* would be hard, because logtape.c doesn't know where one run ends and

0 commit comments

Comments
 (0)








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/postgrespro/postgres_cluster/commit/95b52351fe966c93791462274dfa7af7e50d2da1

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy