pg_dump: Strict names with no matching schema

sfrost · sfrost · commit abfd0095c1e1 · 2017-01-10T11:34:51.000-05:00
When using pg_dump --strict-names and a schema pattern which doesn't
match any schemas (eg: --schema='nonexistant*'), we were incorrectly
throwing an error claiming no tables were found when, really, there
were no schemas found:

  -&gt; pg_dump --strict-names --schema='nonexistant*'
  pg_dump: no matching tables were found for pattern "nonexistant*"

Fix that by changing the error message to say 'schemas' instead, since
that is what we are actually complaining about.

Noticed while testing pg_dump error cases.

Back-patch to 9.6 where --strict-names and this error message were
introduced.
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -1216,7 +1216,7 @@ expand_schema_name_patterns(Archive *fout,
 
 		res = ExecuteSqlQuery(fout, query->data, PGRES_TUPLES_OK);
 		if (strict_names && PQntuples(res) == 0)
-			exit_horribly(NULL, "no matching tables were found for pattern \"%s\"\n", cell->val);
+			exit_horribly(NULL, "no matching schemas were found for pattern \"%s\"\n", cell->val);
 
 		for (i = 0; i < PQntuples(res); i++)
 		{

Original file line number	Diff line number	Diff line change
`@@ -1216,7 +1216,7 @@ expand_schema_name_patterns(Archive *fout,`
`1216`	`1216`
`1217`	`1217`	`res = ExecuteSqlQuery(fout, query->data, PGRES_TUPLES_OK);`
`1218`	`1218`	`if (strict_names && PQntuples(res) == 0)`
`1219`		`- exit_horribly(NULL, "no matching tables were found for pattern \"%s\"\n", cell->val);`
	`1219`	`+ exit_horribly(NULL, "no matching schemas were found for pattern \"%s\"\n", cell->val);`
`1220`	`1220`
`1221`	`1221`	`for (i = 0; i < PQntuples(res); i++)`
`1222`	`1222`	`{`