On Mon, 3 Sep 2001 22:01:17 -0500, you wrote:

bmomjian · bmomjian · commit afa178e7e211 · 2001-09-06T18:26:37.000Z
&gt;public boolean isWritable(int column) throws SQLException
&gt;{
&gt;        if (isReadOnly(column))
&gt;                return true;
&gt;        else
&gt;                return false;
&gt;}

The author probably intended:

    public boolean isWritable(int column) throws SQLException
    {
        return !isReadOnly(column);
    }

And if he would have coded it this way he wouldn't have made
this mistake :-)

&gt;hence, isWritable() will always return false. this is something
&gt;of a problem :)

Why exactly? In a way, true is just as incorrect as false, and
perhaps it should throw "not implemented". But I guess that
would be too non-backwardly-compatible.

&gt;let me know if i can provide further information.

Will you submit a patch?

Regards,
Ren? Pijlman &lt;rene@lab.applinet.nl&gt;
diff --git a/src/interfaces/jdbc/org/postgresql/jdbc1/ResultSetMetaData.java b/src/interfaces/jdbc/org/postgresql/jdbc1/ResultSetMetaData.java
@@ -419,10 +419,7 @@ public boolean isReadOnly(int column) throws SQLException
    */
   public boolean isWritable(int column) throws SQLException
   {
-    if (isReadOnly(column))
-      return true;
-    else
-      return false;
+    return !isReadOnly(column);
   }
   
   /**
diff --git a/src/interfaces/jdbc/org/postgresql/jdbc2/ResultSetMetaData.java b/src/interfaces/jdbc/org/postgresql/jdbc2/ResultSetMetaData.java
@@ -414,10 +414,7 @@ public boolean isReadOnly(int column) throws SQLException
    */
   public boolean isWritable(int column) throws SQLException
   {
-    if (isReadOnly(column))
-      return true;
-    else
-      return false;
+    return !isReadOnly(column);
   }
   
   /**

Original file line number	Diff line number	Diff line change
`@@ -419,10 +419,7 @@ public boolean isReadOnly(int column) throws SQLException`
`419`	`419`	`*/`
`420`	`420`	`public boolean isWritable(int column) throws SQLException`
`421`	`421`	`{`
`422`		`- if (isReadOnly(column))`
`423`		`- return true;`
`424`		`- else`
`425`		`- return false;`
	`422`	`+ return !isReadOnly(column);`
`426`	`423`	`}`
`427`	`424`
`428`	`425`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -414,10 +414,7 @@ public boolean isReadOnly(int column) throws SQLException`
`414`	`414`	`*/`
`415`	`415`	`public boolean isWritable(int column) throws SQLException`
`416`	`416`	`{`
`417`		`- if (isReadOnly(column))`
`418`		`- return true;`
`419`		`- else`
`420`		`- return false;`
	`417`	`+ return !isReadOnly(column);`
`421`	`418`	`}`
`422`	`419`
`423`	`420`	`/**`