Make INSTALL makefile rule more robust

petere · petere · commit bb874e30fbf9 · 2019-01-13T10:50:36.000+01:00
With the previous rule, if pandoc was missing, a zero-length output
file would be created without an error from make.  To improve that,
write the rule as two separate commands without a pipe.

Reported-by: Tom Lane &lt;tgl@sss.pgh.pa.us&gt;
diff --git a/doc/src/sgml/Makefile b/doc/src/sgml/Makefile
@@ -103,7 +103,9 @@ ICONV = iconv
 PANDOC = pandoc
 
 INSTALL: % : %.html
-	$(PANDOC) $< -t plain | $(ICONV) -f utf8 -t us-ascii//TRANSLIT > $@
+	$(PANDOC) -t plain -o $@.tmp $<
+	$(ICONV) -f utf8 -t us-ascii//TRANSLIT $@.tmp > $@
+	rm $@.tmp
 
 INSTALL.html: %.html : stylesheet-text.xsl %.xml
 	$(XMLLINT) --noout --valid $*.xml
