Fix unportable usage of <ctype.h> functions.

tglsfdc · tglsfdc · commit cb0ca0c9953a · 2016-03-06T18:23:53.000-05:00
isdigit(), isspace(), etc are likely to give surprising results if passed a signed char. We should always cast the argument to unsigned char to avoid that. Error in commit d78a7d9, found by buildfarm member gaur.
diff --git a/src/backend/tsearch/spell.c b/src/backend/tsearch/spell.c
@@ -363,7 +363,7 @@ DecodeFlag(IspellDict *Conf, char *sflag, char **sflagnext)
 									 errmsg("non-ASCII affix flag \"%s\"",
 											sflag)));
 						}
-						else if (isdigit(*next))
+						else if (isdigit((unsigned char) *next))
 						{
 							if (!met_comma)
 								ereport(ERROR,
@@ -381,7 +381,7 @@ DecodeFlag(IspellDict *Conf, char *sflag, char **sflagnext)
 												sflag)));
 							met_comma = true;
 						}
-						else if (!isspace(*next))
+						else if (!isspace((unsigned char) *next))
 						{
 							ereport(ERROR,
 									(errcode(ERRCODE_CONFIG_FILE_ERROR),

Original file line number	Diff line number	Diff line change
`@@ -363,7 +363,7 @@ DecodeFlag(IspellDict Conf, char sflag, char **sflagnext)`
`363`	`363`	`errmsg("non-ASCII affix flag \"%s\"",`
`364`	`364`	`sflag)));`
`365`	`365`	`}`
`366`		`- else if (isdigit(*next))`
	`366`	`+ else if (isdigit((unsigned char) *next))`
`367`	`367`	`{`
`368`	`368`	`if (!met_comma)`
`369`	`369`	`ereport(ERROR,`
`@@ -381,7 +381,7 @@ DecodeFlag(IspellDict Conf, char sflag, char **sflagnext)`
`381`	`381`	`sflag)));`
`382`	`382`	`met_comma = true;`
`383`	`383`	`}`
`384`		`- else if (!isspace(*next))`
	`384`	`+ else if (!isspace((unsigned char) *next))`
`385`	`385`	`{`
`386`	`386`	`ereport(ERROR,`
`387`	`387`	`(errcode(ERRCODE_CONFIG_FILE_ERROR),`