Instruct Coverity using an assertion.

nmisch · nmisch · commit d4b686af0b8f · 2015-12-05T03:04:17.000-05:00
This should make Coverity deduce that plperl_call_perl_func() does not
dereference NULL argtypes.  Back-patch to 9.5, where the affected code
was introduced.

Michael Paquier
diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.c
@@ -2111,8 +2111,10 @@ plperl_call_perl_func(plperl_proc_desc *desc, FunctionCallInfo fcinfo)
 	PUSHMARK(SP);
 	EXTEND(sp, desc->nargs);
 
+	/* Get signature for true functions; inline blocks have no args. */
 	if (fcinfo->flinfo->fn_oid)
 		get_func_signature(fcinfo->flinfo->fn_oid, &argtypes, &nargs);
+	Assert(nargs == desc->nargs);
 
 	for (i = 0; i < desc->nargs; i++)
 	{

Original file line number	Diff line number	Diff line change
`@@ -2111,8 +2111,10 @@ plperl_call_perl_func(plperl_proc_desc *desc, FunctionCallInfo fcinfo)`
`2111`	`2111`	`PUSHMARK(SP);`
`2112`	`2112`	`EXTEND(sp, desc->nargs);`
`2113`	`2113`
	`2114`	`+ /* Get signature for true functions; inline blocks have no args. */`
`2114`	`2115`	`if (fcinfo->flinfo->fn_oid)`
`2115`	`2116`	`get_func_signature(fcinfo->flinfo->fn_oid, &argtypes, &nargs);`
	`2117`	`+ Assert(nargs == desc->nargs);`
`2116`	`2118`
`2117`	`2119`	`for (i = 0; i < desc->nargs; i++)`
`2118`	`2120`	`{`