Fix bug in the test of file descriptor of current WAL file in pg_receivexlog.

MasaoFujii · MasaoFujii · commit d5f4df7264ec · 2014-11-19T19:10:04.000+09:00
In pg_receivexlog, in order to check whether the current WAL file is
being opened or not, its file descriptor has to be checked against -1
as an invalid value. But, oops, 7900e94 added the incorrect test
checking the descriptor against 1. This commit fixes that bug.

Back-patch to 9.4 where the bug was added.

Spotted by Magnus Hagander
diff --git a/src/bin/pg_basebackup/receivelog.c b/src/bin/pg_basebackup/receivelog.c
@@ -1021,7 +1021,7 @@ ProcessKeepaliveMsg(PGconn *conn, char *copybuf, int len,
 	if (replyRequested && still_sending)
 	{
 		if (reportFlushPosition && lastFlushPosition < blockpos &&
-			walfile != 1)
+			walfile != -1)
 		{
 			/*
 			 * If a valid flush location needs to be reported,

Original file line number	Diff line number	Diff line change
`@@ -1021,7 +1021,7 @@ ProcessKeepaliveMsg(PGconn conn, char copybuf, int len,`
`1021`	`1021`	`if (replyRequested && still_sending)`
`1022`	`1022`	`{`
`1023`	`1023`	`if (reportFlushPosition && lastFlushPosition < blockpos &&`
`1024`		`- walfile != 1)`
	`1024`	`+ walfile != -1)`
`1025`	`1025`	`{`
`1026`	`1026`	`/*`
`1027`	`1027`	`* If a valid flush location needs to be reported,`