Fix memory leak in PLySequence_ToJsonbValue()

akorotkov · akorotkov · commit dad8bed04ab9 · 2018-06-15T15:01:46.000+03:00
PyObject returned from PySequence_GetItem() is not released. Similar code in PLyMapping_ToJsonbValue() is correct, because according to Python documentation PyList_GetItem() and PyTuple_GetItem() return a borrowed reference while PySequence_GetItem() returns new reference. contrib/jsonb_plpython is new in PostgreSQL 11, no backpatch is needed. Author: Nikita Glukhov Discussion: https://postgr.es/m/6001af16-b242-2527-bc7e-84b8a959163b%40postgrespro.ru
diff --git a/contrib/jsonb_plpython/jsonb_plpython.c b/contrib/jsonb_plpython/jsonb_plpython.c
@@ -308,6 +308,8 @@ PLySequence_ToJsonbValue(PyObject *obj, JsonbParseState **jsonb_state)
 		PyObject   *value = PySequence_GetItem(obj, i);
 
 		(void) PLyObject_ToJsonbValue(value, jsonb_state, true);
+
+		Py_XDECREF(value);
 	}
 
 	return pushJsonbValue(jsonb_state, WJB_END_ARRAY, NULL);

Original file line number	Diff line number	Diff line change
`@@ -308,6 +308,8 @@ PLySequence_ToJsonbValue(PyObject obj, JsonbParseState *jsonb_state)`
`308`	`308`	`PyObject *value = PySequence_GetItem(obj, i);`
`309`	`309`
`310`	`310`	`(void) PLyObject_ToJsonbValue(value, jsonb_state, true);`
	`311`	`+`
	`312`	`+ Py_XDECREF(value);`
`311`	`313`	`}`
`312`	`314`
`313`	`315`	`return pushJsonbValue(jsonb_state, WJB_END_ARRAY, NULL);`