If we don't have a backup-end-location, don't claim we've reached it.

hlinnaka · hlinnaka · commit dd7353dde82a · 2012-11-28T15:14:27.000+02:00
This was apparently a typo, which caused recovery to think that it
immediately reached the end of backup, and allowed the database to start
up too early.

Reported by Jeff Janes. Backpatch to 9.2, where this code was introduced.
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
@@ -5859,7 +5859,7 @@ StartupXLOG(void)
 				/* Pop the error context stack */
 				error_context_stack = errcallback.previous;
 
-				if (!XLogRecPtrIsInvalid(ControlFile->backupStartPoint) &&
+				if (!XLogRecPtrIsInvalid(ControlFile->backupEndPoint) &&
 					XLByteLE(ControlFile->backupEndPoint, EndRecPtr))
 				{
 					/*

Original file line number	Diff line number	Diff line change
`@@ -5859,7 +5859,7 @@ StartupXLOG(void)`
`5859`	`5859`	`/* Pop the error context stack */`
`5860`	`5860`	`error_context_stack = errcallback.previous;`
`5861`	`5861`
`5862`		`- if (!XLogRecPtrIsInvalid(ControlFile->backupStartPoint) &&`
	`5862`	`+ if (!XLogRecPtrIsInvalid(ControlFile->backupEndPoint) &&`
`5863`	`5863`	`XLByteLE(ControlFile->backupEndPoint, EndRecPtr))`
`5864`	`5864`	`{`
`5865`	`5865`	`/*`