Content-Length: 266141 | pFad | http://github.com/postgrespro/postgres_cluster/commit/ef2a83323c3b5ecbdcd113a61c4eddf968d29508

8F pgbench: Remove dead code · postgrespro/postgres_cluster@ef2a833 · GitHub
Skip to content

Commit ef2a833

Browse files
committed
pgbench: Remove dead code
doConnect() never returns connections in state CONNECTION_BAD, so checking for that is pointless. Remove the code that does. This code has been dead since ba708ea, 20 years ago. Discussion: https://postgr.es/m/20210126195224.GA20361@alvherre.pgsql Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
1 parent 75e3cca commit ef2a833

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

src/bin/pgbench/pgbench.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6044,13 +6044,6 @@ main(int argc, char **argv)
60446044
if (con == NULL)
60456045
exit(1);
60466046

6047-
if (PQstatus(con) == CONNECTION_BAD)
6048-
{
6049-
pg_log_fatal("connection to database \"%s\" failed: %s",
6050-
PQdb(con) ? PQdb(con) : "", PQerrorMessage(con));
6051-
exit(1);
6052-
}
6053-
60546047
if (internal_script_used)
60556048
GetTableInfo(con, scale_given);
60566049

0 commit comments

Comments
 (0)








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/postgrespro/postgres_cluster/commit/ef2a83323c3b5ecbdcd113a61c4eddf968d29508

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy